netdev - Re: [PATCH net v3 3/3] ovpn: use datagram_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd5478c6-8d48-469e-a6ac-02714d19d2b5@openvpn.net>
Date: Thu, 23 Oct 2025 10:03:51 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Sabrina Dubroca <sd@...asysnail.net>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, Ralf Lici <ralf@...delbit.com>
Subject: Re: [PATCH net v3 3/3] ovpn: use datagram_poll_queue for socket
 readiness in TCP

On 21/10/2025 12:09, Ralf Lici wrote:
> openvpn TCP encapsulation uses a custom queue to deliver packets to
> userspace. Currently it relies on datagram_poll, which checks
> sk_receive_queue, leading to false readiness signals when that queue
> contains non-userspace packets.
> 
> Switch ovpn_tcp_poll to use datagram_poll_queue with the peer's
> user_queue, ensuring poll only signals readiness when userspace data is
> actually available. Also refactor ovpn_tcp_poll in order to enforce the
> assumption we can make on the lifetime of ovpn_sock and peer.
> 
> Fixes: 11851cbd60ea ("ovpn: implement TCP transport")
> Signed-off-by: Antonio Quartulli <antonio@...nvpn.net>
> Signed-off-by: Ralf Lici <ralf@...delbit.com>

Jakub,

fell free to merge this commit directly to net, as it's not useful to 
have it go through my tree without the other patches.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.