netdev - Re: [PATCH net-next v3 01/15] net: Add bind-queue operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c93a71ea-fddf-4f0c-9a01-ca5f1729037a@iogearbox.net>
Date: Fri, 24 Oct 2025 12:15:36 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
 razor@...ckwall.org, pabeni@...hat.com, willemb@...gle.com, sdf@...ichev.me,
 john.fastabend@...il.com, martin.lau@...nel.org, jordan@...fe.io,
 maciej.fijalkowski@...el.com, magnus.karlsson@...el.com, dw@...idwei.uk,
 toke@...hat.com, yangzhenze@...edance.com, wangdongdong.6@...edance.com
Subject: Re: [PATCH net-next v3 01/15] net: Add bind-queue operation

On 10/24/25 4:12 AM, Jakub Kicinski wrote:
> On Mon, 20 Oct 2025 18:23:41 +0200 Daniel Borkmann wrote:
>> +      name: bind-queue
>> +      doc: |
>> +        Bind a physical netdevice queue to a virtual one. The binding
>> +        creates a queue pair, where a queue can reference its peer queue.
>> +        This is useful for memory providers and AF_XDP operations which
>> +        take an ifindex and queue id to allow auch applications to bind
>> +        against virtual devices in containers.
>> +      attribute-set: queue-pair
> 
>        flags: [admin-perm]
> 
> right?
Oh, yes good catch! I've just checked for other instances in that file, don't
we also need the same flag for bind-tx? bind-rx for example has it, only the
info dumps don't. I can cook a patch for net

diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index e1735b486222..59c71a76b26f 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -827,6 +827,7 @@ operations:
        name: bind-tx
        doc: Bind dmabuf to netdev for TX
        attribute-set: dmabuf
+      flags: [admin-perm]
        do:
          request:
            attributes:
diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c
index 8a973bc5588a..3f044b864ff7 100644
--- a/net/core/netdev-genl-gen.c
+++ b/net/core/netdev-genl-gen.c
@@ -220,7 +220,7 @@ static const struct genl_split_ops netdev_nl_ops[] = {
                 .doit           = netdev_nl_bind_tx_doit,
                 .policy         = netdev_bind_tx_nl_policy,
                 .maxattr        = NETDEV_A_DMABUF_FD,
-               .flags          = GENL_CMD_CAP_DO,
+               .flags          = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
         },
         {
                 .cmd            = NETDEV_CMD_BIND_QUEUE,