netdev - Re: [PATCH net-next 0/8] net: stmmac: hwif.c cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a1cacb5-0005-4b32-8e68-624644a38f92@bootlin.com>
Date: Fri, 24 Oct 2025 12:53:55 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next 0/8] net: stmmac: hwif.c cleanups

Hi Russell,

On 24/10/2025 12:48, Russell King (Oracle) wrote:
> On Fri, Oct 24, 2025 at 08:44:07AM +0200, Maxime Chevallier wrote:
>> Hello Russell,
>>
>> On 23/10/2025 11:36, Russell King (Oracle) wrote:
>>> Hi,
>>>
>>> This series cleans up hwif.c:
>>>
>>> - move the reading of the version information out of stmmac_hwif_init()
>>>   into its own function, stmmac_get_version(), storing the result in a
>>>   new struct.
>>>
>>> - simplify stmmac_get_version().
>>>
>>> - read the version register once, passing it to stmmac_get_id() and
>>>   stmmac_get_dev_id().
>>>
>>> - move stmmac_get_id() and stmmac_get_dev_id() into
>>>   stmmac_get_version()
>>>
>>> - define version register fields and use FIELD_GET() to decode
>>>
>>> - start tackling the big loop in stmmac_hwif_init() - provide a
>>>   function, stmmac_hwif_find(), which looks up the hwif entry, thus
>>>   making a much smaller loop, which improves readability of this code.
>>>
>>> - change the use of '^' to '!=' when comparing the dev_id, which is
>>>   what is really meant here.
>>>
>>> - reorganise the test after calling stmmac_hwif_init() so that we
>>>   handle the error case in the indented code, and the success case
>>>   with no indent, which is the classical arrangement.
>>>
>>>  drivers/net/ethernet/stmicro/stmmac/common.h |   3 +
>>>  drivers/net/ethernet/stmicro/stmmac/hwif.c   | 166 +++++++++++++++------------
>>>  2 files changed, 98 insertions(+), 71 deletions(-)
>>
>> I didn't have the bandwidth to do a full review, however I ran tests
>> with this series on dwmac-socfpga and dwmac-stm32, no regressions found.
>>
>> For the series,
>>
>> Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> 
> Thanks, it's good to have someone else testing. I do need to post v2
> with some tweaks to patches 2, 3 and 4 due to a typo that gets
> eliminated in later patches. "verison*" -> "version*" in one instance.
> 
If it's only typos, feel free to keep the t-b tag :)

Thanks,

Maxime