netdev - Re: [PATCH v1 net-next 3/5] neighbour: Convert RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+nC-+NpenTPjGUZ0fA-TsNyWUK35PF70fHNBf4BrdPDA@mail.gmail.com>
Date: Fri, 24 Oct 2025 05:34:51 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 3/5] neighbour: Convert RTM_GETNEIGHTBL to RCU.

On Tue, Oct 21, 2025 at 10:40 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> neightbl_dump_info() calls these functions for each neigh_tables[]
> entry:
>
>   1. neightbl_fill_info() for tbl->parms
>   2. neightbl_fill_param_info() for tbl->parms_list (except tbl->parms)
>
> Both functions rely on the table lock (read_lock_bh(&tbl->lock))
> and RTNL is not needed.
>
> Let's fetch the table under RCU and convert RTM_GETNEIGHTBL to RCU.
>
> Note that the first entry of tbl->parms_list is tbl->parms.list and
> embedded in neigh_table, so list_next_entry() is safe.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>