netdev - Re: [External] : Re: [Intel-wired-lan] [PATCH net-next v2 1/2] idpf: correct queue index in Rx allocation error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c01f1be-509e-4556-9543-1bf042f42914@oracle.com>
Date: Fri, 24 Oct 2025 18:41:13 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
        andrew+netdev@...n.ch, kuba@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        alok.a.tiwarilinux@...il.com
Subject: Re: [External] : Re: [Intel-wired-lan] [PATCH net-next v2 1/2] idpf:
 correct queue index in Rx allocation error messages



On 10/23/2025 9:05 PM, Alexander Lobakin wrote:
>> @@ -940,7 +940,7 @@ static int idpf_rx_desc_alloc_all(struct idpf_vport *vport)
>>   			if (err) {
>>   				pci_err(vport->adapter->pdev,
>>   					"Memory allocation for Rx Buffer Queue %u failed\n",
>> -					i);
>> +					j);
>>   				goto err_out;
> Both are not valid.
> 
> @i is the index of the queue group. @j is the index of the queue
> *inside* this queue group.
> Since one queue group can contain only one Rx queue and 2 buffer queues,
> these pci_err() would only print "Rx queue 0" and "Rx Buffer Queue 0/1",
> which is even less useful than before.
> 
> If you want to "fix" this, you can print rxq->idx for Rx queues and
> `(i * vport->num_bufqs_per_qgrp) + j` for buffer queues. This would
> at least print unique index for each queue.
> 
> Alternatively, expand the message to something like:
> 
> "Memory allocation for Rx queue %u from queue group %u failed\n", j, i);
> 
> (same for buffer queues)
> 
>>   			}
>>   		}

Thanks, Alexander. I will send v3 with both the Rx queue and queue 
group(j, i).

Thanks
Alok