netdev - Re: [PATCH net] net: gro_cells: fix lock imbalance in gro_cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024134703.mER1deGv@linutronix.de>
Date: Fri, 24 Oct 2025 15:47:03 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com,
	syzbot+f9651b9a8212e1c8906f@...kaller.appspotmail.com
Subject: Re: [PATCH net] net: gro_cells: fix lock imbalance in
 gro_cells_receive()

On 2025-10-20 16:11:14 [+0000], Eric Dumazet wrote:
> syzbot found that the local_unlock_nested_bh() call was
> missing in some cases.

Thank you Eric.

> Given the introduction of @have_bh_lock variable, it seems the author
> intent was to have the local_unlock_nested_bh() after the @unlock label.

Indeed that was the intention. It is even noted in the diffstat that
this the reason the variable.

Sebastian