netdev - Re: [PATCH v3 net-next 2/8] sctp: Don't copy sk_sndbuf and sk_rcvbuf in sctp_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_dJGFQG9jx5KioFn3-z01w3xO=MeWxwsQ1fUHdkNN6NGw@mail.gmail.com>
Date: Fri, 24 Oct 2025 09:55:55 -0400
From: Xin Long <lucien.xin@...il.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org, 
	linux-sctp@...r.kernel.org
Subject: Re: [PATCH v3 net-next 2/8] sctp: Don't copy sk_sndbuf and sk_rcvbuf
 in sctp_sock_migrate().

On Thu, Oct 23, 2025 at 7:17 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> sctp_sock_migrate() is called from 2 places.
>
> 1) sctp_accept() calls sp->pf->create_accept_sk() before
>    sctp_sock_migrate(), and sp->pf->create_accept_sk() calls
>    sctp_copy_sock().
>
> 2) sctp_do_peeloff() also calls sctp_copy_sock() before
>    sctp_sock_migrate().
>
> sctp_copy_sock() copies sk_sndbuf and sk_rcvbuf from the
> parent socket.
>
> Let's not copy the two fields in sctp_sock_migrate().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
Acked-by: Xin Long <lucien.xin@...il.com>