netdev - Re: [PATCH net-next 0/3] icmp: Add RFC 5837 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024080455.7a0220d2@kernel.org>
Date: Fri, 24 Oct 2025 08:04:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
 edumazet@...gle.com, horms@...nel.org, dsahern@...nel.org,
 petrm@...dia.com, willemb@...gle.com, daniel@...earbox.net, fw@...len.de,
 ishaangandhi@...il.com, rbonica@...iper.net, tom@...bertland.com
Subject: Re: [PATCH net-next 0/3] icmp: Add RFC 5837 support

On Fri, 24 Oct 2025 17:50:56 +0300 Ido Schimmel wrote:
> On Thu, Oct 23, 2025 at 06:48:57PM -0700, Jakub Kicinski wrote:
> > Current one has traceroute updated but not traceroute6
> > https://netdev-3.bots.linux.dev/vmksft-net/results/354402/27-traceroute-sh/stdout
> > 
> > This doesn't sound related to the traceroute version tho:
> > 
> > # 34.51 [+6.48] TEST: IPv4 traceroute with ICMP extensions                          [FAIL]
> > # 34.51 [+0.00] Unsupported sysctl value was not rejected  
> 
> Hmm, which sysctl version do you have?
> 
> I have:
> 
> $ sysctl --version
> sysctl from procps-ng 4.0.4
> 
> I just compiled 3.3.17 and I get:

$ sysctl --version
sysctl from procps-ng 3.3.17

Amazon Linux 🤷️

> # /home/idosch/tmp/procps-v3.3.17/sysctl -wq net.ipv4.icmp_errors_extension_mask=0x80
> sysctl: setting key "net.ipv4.icmp_errors_extension_mask": Invalid argument
> # echo $?
> 0
> 
> Which can explain the failure.
> 
> Please let me know if that's the issue and if you want me to replace
> this with:
> 
> echo 0x80 > /proc/sys/net/ipv4/icmp_errors_extension_mask

Let's go with the echo, if you don't mind.