netdev - Re: [PATCH net-next v3 02/15] net: Implement netdev_nl_bind_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023190851.435e2afa@kernel.org>
Date: Thu, 23 Oct 2025 19:08:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 bpf@...r.kernel.org, davem@...emloft.net, razor@...ckwall.org,
 willemb@...gle.com, sdf@...ichev.me, john.fastabend@...il.com,
 martin.lau@...nel.org, jordan@...fe.io, maciej.fijalkowski@...el.com,
 magnus.karlsson@...el.com, dw@...idwei.uk, toke@...hat.com,
 yangzhenze@...edance.com, wangdongdong.6@...edance.com
Subject: Re: [PATCH net-next v3 02/15] net: Implement
 netdev_nl_bind_queue_doit

On Thu, 23 Oct 2025 14:48:15 +0200 Daniel Borkmann wrote:
> On 10/23/25 12:27 PM, Paolo Abeni wrote:
> > On 10/20/25 6:23 PM, Daniel Borkmann wrote:  
> >> +	if (!src_dev->dev.parent) {
> >> +		err = -EOPNOTSUPP;
> >> +		NL_SET_ERR_MSG(info->extack,
> >> +			       "Source device is a virtual device");
> >> +		goto err_unlock_src_dev;
> >> +	}  
> > 
> > Is this check strictly needed? I think that if we relax it, it could be
> > simpler to create all-virtual selftests.  
> It is needed given we need to always ensure lock ordering for the two devices,
> that is, the order is always from the virtual to the physical device.

You do seem to be taking the lock before you check if the device was
the type you expected tho.