netdev - Re: [PATCH v4 1/1] nft_ct: Added nfct_seqadj_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPuo22KKi2CtD57q@strlen.de>
Date: Fri, 24 Oct 2025 18:27:07 +0200
From: Florian Westphal <fw@...len.de>
To: Andrii Melnychenko <a.melnychenko@...s.io>
Cc: pablo@...filter.org, kadlec@...filter.org, phil@....cc,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/1] nft_ct: Added nfct_seqadj_ext_add() for DNAT'ed
 conntrack.

Andrii Melnychenko <a.melnychenko@...s.io> wrote:
> There is an issue with the missed seqadj extension for NAT'ed
> conntrack setup with nft. Sequence adjustment may be required
> for FTP traffic with PASV/EPSV modes.

Patch looks good, thanks.

> Oct 16 10:24:44 vyos kernel: Missing nfct_seqadj_ext_add() setup call
> Oct 16 10:24:44 vyos kernel: WARNING: CPU: 1 PID: 0 at
> net/netfilter/nf_conntrack_seqadj.c:41 nf_ct_seqadj_set+0xbf/0xe0
> [nf_conntrack]

This is useful.

> configfs(E) virtio_rng(E) rng_core(E) ip_tables(E) x_tables(E)
> autofs4(E) usb_storage(E) ohci_hcd(E) uhci_hcd(E) ehci_hcd(E) sd_mod(E)

[..]

For the future, please consider trimming this to the essentials.
Loaded modules etc or date are not relevant info that needs to be in
the changelog.

I'll trim this before applying, no need to resend.

Thanks for taking the time to track down the root cause of this bug.