netdev - Re: [PATCH v1 net-next 5/5] neighbour: Convert rwlock of struct neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUBd8ZW1BZMN0FAPbr=MzP7drSN8YsxdJLmQVeTfmvNqVw@mail.gmail.com>
Date: Fri, 24 Oct 2025 09:42:36 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 5/5] neighbour: Convert rwlock of struct
 neigh_table to spinlock.

On Fri, Oct 24, 2025 at 5:31 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Tue, Oct 21, 2025 at 10:40 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
> >
> > Only neigh_for_each() and neigh_seq_start/stop() are on the
> > reader side of neigh_table.lock.
> >
> > Let's convert rwlock to the plain spinlock.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> >
>
> Do we still need _bh prefix ?

Yes, I think _bh is just for IPv6 ndisc calling neigh_update().