netdev - Re: [PATCH for-next 1/1] net: jme: migrate to dma_map_phys instead of map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPu3C8QUYLYE8ZpG@horms.kernel.org>
Date: Fri, 24 Oct 2025 18:27:39 +0100
From: Simon Horman <horms@...nel.org>
To: Chu Guangqing <chuguangqing@...pur.com>
Cc: cooldavid@...ldavid.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next 1/1] net: jme: migrate to dma_map_phys instead
 of map_page

On Fri, Oct 24, 2025 at 03:07:34PM +0800, Chu Guangqing wrote:
> After introduction of dma_map_phys(), there is no need to convert
> from physical address to struct page in order to map page. So let's
> use it directly.
> 
> Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>

Although there have been a number minor updates since, mainly for in-kernel
API changes, it seems to me that the last change of substance to this
driver - a feature or bug fix - was the following commit in 2016.

commit 81422e672f81 ("jme: Fix device PM wakeup API usage")

So, unless there is a tree-wide effort to move to the pattern you describe,
I am wondering if it would be better to just leave this code as-is.

Quoting documentation:

1.6.6. Clean-up patches¶

Netdev discourages patches which perform simple clean-ups, which are not in the context of other work. For example:

    Addressing checkpatch.pl, and other trivial coding style warnings

    Addressing Local variable ordering issues

    Conversions to device-managed APIs (devm_ helpers)

This is because it is felt that the churn that such changes produce comes at a greater cost than the value of such clean-ups.

Conversely, spelling and grammar fixes are not discouraged.

https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches