netdev - Re: [PATCH net-next] tcp: Remove unnecessary null check in tcp_inbound_md5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176127361900.3327514.1259136362900975267.git-patchwork-notify@kernel.org>
Date: Fri, 24 Oct 2025 02:40:19 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Eric Biggers <ebiggers@...nel.org>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, ncardwell@...gle.com,
 kuniyu@...gle.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, dsahern@...nel.org, 0x7f454c46@...il.com,
 dan.carpenter@...aro.org
Subject: Re: [PATCH net-next] tcp: Remove unnecessary null check in
 tcp_inbound_md5_hash()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 22 Oct 2025 15:12:09 -0700 you wrote:
> The 'if (!key && hash_location)' check in tcp_inbound_md5_hash() implies
> that hash_location might be null.  However, later code in the function
> dereferences hash_location anyway, without checking for null first.
> Fortunately, there is no real bug, since tcp_inbound_md5_hash() is
> called only with non-null values of hash_location.
> 
> Therefore, remove the unnecessary and misleading null check of
> hash_location.  This silences a Smatch static checker warning
> (https://lore.kernel.org/netdev/aPi4b6aWBbBR52P1@stanley.mountain/)
> 
> [...]

Here is the summary with links:
  - [net-next] tcp: Remove unnecessary null check in tcp_inbound_md5_hash()
    https://git.kernel.org/netdev/net-next/c/05774d7e4201

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html