netdev - Re: [net,PATCH] net: phy: dp83869: fix STRAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <825c8662-831d-43e0-ba28-a1373f9d5a9d@lunn.ch>
Date: Fri, 24 Oct 2025 02:24:35 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Marek Vasut <marek.vasut+renesas@...lbox.org>
Cc: netdev@...r.kernel.org, Thanh Quan <thanh.quan.xn@...esas.com>,
	Hai Pham <hai.pham.ud@...esas.com>,
	"David S. Miller" <davem@...emloft.net>,
	Dan Murphy <dmurphy@...com>, Eric Dumazet <edumazet@...gle.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [net,PATCH] net: phy: dp83869: fix STRAP_OPMODE bitmask

On Fri, Oct 24, 2025 at 12:39:45AM +0200, Marek Vasut wrote:
> From: Thanh Quan <thanh.quan.xn@...esas.com>
> 
> According to the TI DP83869HM datasheet Revision D (June 2025), section
> 7.6.1.41 STRAP_STS Register, the STRAP_OPMODE bitmask is bit [11:9].
> Fix this.

It is a good idea to state in the commit message what the bad
behaviour is which the patch fixes. Somebody looking through the
patches can then decide if they need to cherry-pick the patch into
their dead vendor tree, etc.

Please add to the commit message what issue you where seeing which
made you create this patch.

    Andrew

---
pw-bot: cr