netdev - Re: [PATCH net-next] net: stmmac: mdio: fix smatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d840dff-60d1-4b7c-bda8-04704fc4c81a@gmail.com>
Date: Sat, 25 Oct 2025 20:33:37 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 David Miller <davem@...emloft.net>
Cc: "moderated list:ARM/STM32 ARCHITECTURE"
 <linux-stm32@...md-mailman.stormreply.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Russell King - ARM Linux <linux@...linux.org.uk>
Subject: Re: [PATCH net-next] net: stmmac: mdio: fix smatch warning

On 10/24/2025 9:26 PM, Heiner Kallweit wrote:
> max_addr is the max number of addresses, not the highest possible address,
> therefore check phydev->mdio.addr > max_addr isn't correct.
> To fix this change the semantics of max_addr, so that it represents
> the highest possible address. IMO this is also a little bit more intuitive
> wrt name max_addr.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Reported-by: Simon Horman <horms@...nel.org>
> Fixes: 4a107a0e8361 ("net: stmmac: mdio: use phy_find_first to simplify stmmac_mdio_register")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---

CI complains about the patch title, so I'll change it and send a v2.

--
pw-bot: cr