netdev - Re: [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPxCVRvMlpOQPbhL@x130>
Date: Fri, 24 Oct 2025 20:21:57 -0700
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
	Jason Gunthorpe <jgg@...dia.com>, linux-rdma@...r.kernel.org,
	netdev@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
	Adithya Jayachandran <ajayachandra@...dia.com>,
	Mark Bloch <mbloch@...dia.com>
Subject: Re: [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from
 device

On 22 Oct 17:10, Jakub Kicinski wrote:
>On Tue, 21 Oct 2025 19:12:21 -0700 Saeed Mahameed wrote:
>> On 21 Oct 16:47, Jakub Kicinski wrote:
>> >On Wed, 15 Oct 2025 18:40:55 -0700 Saeed Mahameed wrote:
>> >> Before this patch during either switchdev or legacy mode enablement we
>> >> cleared the mac address of vports between changes. This change allows us
>> >> to preserve the vports mac address between eswitch mode changes.
>> >
>> >Not knowing what exactly a vport is I can't tell whether this preserves
>> >MAC addrs of reprs, the uplink, something else?
>>
>> vport == vf or sf, so VF/SF permanent mac address. It can be set either by
>> iproute vf interface or devlink function interface. For no obvious reason
>> we reset it to 0 on switchdev legacy mode changes.. this patch is fixing
>> that.
>>
>> Of course vport holds more information than just the mac address, e.g GUID,
>> mtu, promisc mode, mulitcast mode, and other stuff.
>
>SG! Would be good to incorporate that into the commit msg if possible.

Makes sense, Done.

Applied to mlx5-next ! thanks for the review.