netdev - Re: [PATCH net-next v3 09/12] net: dsa: lantiq_gswip: add vendor property to setup MII refclk output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faa691db9e8452834f476aac9405cb8d4a70cbcc.camel@siemens.com>
Date: Mon, 27 Oct 2025 11:39:26 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "daniel@...rotopia.org" <daniel@...rotopia.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "olteanv@...il.com"
	<olteanv@...il.com>, "robh@...nel.org" <robh@...nel.org>, "lxu@...linear.com"
	<lxu@...linear.com>, "john@...ozen.org" <john@...ozen.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "yweng@...linear.com"
	<yweng@...linear.com>, "bxu@...linear.com" <bxu@...linear.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"fchan@...linear.com" <fchan@...linear.com>, "ajayaraman@...linear.com"
	<ajayaraman@...linear.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"hauke@...ke-m.de" <hauke@...ke-m.de>, "horms@...nel.org" <horms@...nel.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "jpovazanec@...linear.com"
	<jpovazanec@...linear.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v3 09/12] net: dsa: lantiq_gswip: add vendor
 property to setup MII refclk output

Hi Daniel,

On Sun, 2025-10-26 at 23:47 +0000, Daniel Golle wrote:
> Read boolean Device Tree property "maxlinear,rmii-refclk-out" and switch
> the RMII reference clock to be a clock output rather than an input if it
> is set.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

thanks for the patch!

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

(with GSW145)

> ---
>  drivers/net/dsa/lantiq/lantiq_gswip_common.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/dsa/lantiq/lantiq_gswip_common.c b/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> index 60a83093cd10..bf38ecc13f76 100644
> --- a/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> +++ b/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> @@ -1442,6 +1442,10 @@ static void gswip_phylink_mac_config(struct phylink_config *config,
>  		return;
>  	}
>  
> +	if (of_property_read_bool(dp->dn, "maxlinear,rmii-refclk-out") &&
> +	    !(miicfg & GSWIP_MII_CFG_MODE_RGMII))
> +		miicfg |= GSWIP_MII_CFG_RMII_CLK;
> +

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com