netdev - Re: [PATCH v1] net: phy: dp83867: Disable EEE support as not implemented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539795a1-2a69-4fcb-88e7-ca4e3b13ad7c@lunn.ch>
Date: Mon, 27 Oct 2025 15:41:24 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Russell King <linux@...linux.org.uk>,
	Emanuele Ghidoli <ghidoliemanuele@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v1] net: phy: dp83867: Disable EEE support as not
 implemented

> I was talking together with Emanuele on this topic and we are confused
> on how to proceed.
> 
> >From the various comments and tests in this thread, to me the actual
> code change is correct, the dp83867 does not support EEE and we have to
> explicitly disable it in the dp83867 driver.
> 
> As of now we do not have a clear shared understanding on what is going
> on in the stmmac driver. And the commit message is not correct on this
> regard.
> 
> This patch is already merged [1] in netdev tree, should we send a series
> reverting this commit and another commit with just the same change and a
> different commit message? 

No, if its merged, its merged. What should come out of this is a
learning, please be precise with commit messages, more detail rather
than less, and provide as much supporting evidence as you can for any
claims you make.

> In parallel, unrelated to the dp83867 topic, Emanuele is trying to help
> figuring out why the actual behavior of the stmmac changed after Russell
> refactoring. And it's clear that this change in behavior is not expected.

Great.

	Andrew