netdev - Re: [PATCH net-next v16 01/14] net: homa: define user-visible API for Homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXJAmyd6MuPG6mRA+h0RCnCpPyaSRwnwRRt2aA5+nsumek2-g@mail.gmail.com>
Date: Mon, 27 Oct 2025 08:25:27 -0700
From: John Ousterhout <ouster@...stanford.edu>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com, 
	kuba@...nel.org
Subject: Re: [PATCH net-next v16 01/14] net: homa: define user-visible API for Homa

On Mon, Oct 27, 2025 at 2:37 AM Simon Horman <horms@...nel.org> wrote:
>
> On Wed, Oct 15, 2025 at 11:50:48AM -0700, John Ousterhout wrote:
> > Note: for man pages, see the Homa Wiki at:
> > https://homa-transport.atlassian.net/wiki/spaces/HOMA/overview
> >
> > Signed-off-by: John Ousterhout <ouster@...stanford.edu>
>
> ...
>
> > diff --git a/net/Kconfig b/net/Kconfig
> > index d5865cf19799..92972ff2a78d 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -250,6 +250,7 @@ source "net/bridge/netfilter/Kconfig"
> >  endif # if NETFILTER
> >
> >  source "net/sctp/Kconfig"
> > +source "net/homa/Kconfig"
> >  source "net/rds/Kconfig"
> >  source "net/tipc/Kconfig"
> >  source "net/atm/Kconfig"
>
> Hi John,
>
> I think that the hunk above needs to wait until a patch
> that adds net/homa/Kconfig. As is, this breaks builds.
>
> Possibly the same is also true of the hunk below,
> but the build didn't get that far.


Yep, there was a bug in the script that I used to generate the patch
series; the changes to net/Kconfig and net/Makefile weren't supposed
to appear until the last patch of the series. I have fixed this now.

> > diff --git a/net/Makefile b/net/Makefile
> > index aac960c41db6..71f740e0dc34 100644
> > --- a/net/Makefile
> > +++ b/net/Makefile
> > @@ -43,6 +43,7 @@ ifneq ($(CONFIG_VLAN_8021Q),)
> >  obj-y                                += 8021q/
> >  endif
> >  obj-$(CONFIG_IP_SCTP)                += sctp/
> > +obj-$(CONFIG_HOMA)           += homa/
> >  obj-$(CONFIG_RDS)            += rds/
> >  obj-$(CONFIG_WIRELESS)               += wireless/
> >  obj-$(CONFIG_MAC80211)               += mac80211/
> > --
> > 2.43.0
> >