netdev - Re: [PATCH v3 11/70] ns: add active reference count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a51cwbck.ffs@tglx>
Date: Mon, 27 Oct 2025 17:36:27 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org,
 Josef Bacik <josef@...icpanda.com>, Jeff Layton <jlayton@...nel.org>
Cc: Jann Horn <jannh@...gle.com>, Mike Yuan <me@...dnzj.com>, Zbigniew
 Jędrzejewski-Szmek <zbyszek@...waw.pl>, Lennart Poettering
 <mzxreary@...inter.de>, Daan De Meyer <daan.j.demeyer@...il.com>, Aleksa
 Sarai <cyphar@...har.com>, Amir Goldstein <amir73il@...il.com>, Tejun Heo
 <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, Alexander Viro
 <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
 linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
 bpf@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, netdev@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
 Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v3 11/70] ns: add active reference count

On Fri, Oct 24 2025 at 12:52, Christian Brauner wrote:
> diff --git a/kernel/time/namespace.c b/kernel/time/namespace.c
> index ee05cad288da..2e7c110bd13f 100644
> --- a/kernel/time/namespace.c
> +++ b/kernel/time/namespace.c
> @@ -106,6 +106,7 @@ static struct time_namespace *clone_time_ns(struct user_namespace *user_ns,
>  	ns->offsets = old_ns->offsets;
>  	ns->frozen_offsets = false;
>  	ns_tree_add(ns);
> +	ns_ref_active_get_owner(ns);

It seems all places where ns_ref_active_get_owner() is added it is
preceeded by a variant of ns_tree_add(). So why don't you stilck that
refcount thing into ns_tree_add()? I'm probably missing something here.

Thanks,

        tglx