netdev - RE: [PATCH net-next] net: mana: Implement ndo_tx_timeout and serialize queue resets per port.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA3PR21MB3867E1DE0A3783D14621B220CAFCA@SA3PR21MB3867.namprd21.prod.outlook.com>
Date: Mon, 27 Oct 2025 17:52:07 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Dipayaan Roy <dipayanroy@...ux.microsoft.com>, KY Srinivasan
	<kys@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui
	<DECUI@...rosoft.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Long Li <longli@...rosoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>, "horms@...nel.org"
	<horms@...nel.org>, "shradhagupta@...ux.microsoft.com"
	<shradhagupta@...ux.microsoft.com>, "ssengar@...ux.microsoft.com"
	<ssengar@...ux.microsoft.com>, "ernis@...ux.microsoft.com"
	<ernis@...ux.microsoft.com>, Shiraz Saleem <shirazsaleem@...rosoft.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, Dipayaan Roy
	<dipayanroy@...rosoft.com>
Subject: RE: [PATCH net-next] net: mana: Implement ndo_tx_timeout and
 serialize queue resets per port.



> -----Original Message-----
> From: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
> Sent: Monday, October 27, 2025 7:46 AM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; wei.liu@...nel.org; Dexuan Cui
> <DECUI@...rosoft.com>; andrew+netdev@...n.ch; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; Long Li
> <longli@...rosoft.com>; Konstantin Taranov <kotaranov@...rosoft.com>;
> horms@...nel.org; shradhagupta@...ux.microsoft.com;
> ssengar@...ux.microsoft.com; ernis@...ux.microsoft.com; Shiraz Saleem
> <shirazsaleem@...rosoft.com>; linux-hyperv@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> rdma@...r.kernel.org; Dipayaan Roy <dipayanroy@...rosoft.com>
> Subject: [PATCH net-next] net: mana: Implement ndo_tx_timeout and
> serialize queue resets per port.
> 
> Implement .ndo_tx_timeout for MANA so any stalled TX queue can be detected
> and a device-controlled port reset for all queues can be scheduled to an
> ordered workqueue. The reset for all queues on stall detection is
> recomended by hardware team.
> 
> The change introduces a single ordered workqueue
> ("mana_per_port_queue_reset_wq") with WQ_UNBOUND | WQ_MEM_RECLAIM and
> queues exactly one work_struct per port onto it. This achieves:
> 
>   * Global FIFO across all port reset requests (alloc_ordered_workqueue).
>   * Natural per-port de-duplication: the same work_struct cannot be
>     queued twice while pending/running.
>   * Avoids hogging a per-CPU kworker for long, may-sleep reset paths
>     (WQ_UNBOUND).
>   * Guarantees forward progress during memory pressure
>     (WQ_MEM_RECLAIM rescuer).
> 
> Signed-off-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>

Looks good, except for the comments from Pavan.

Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>