netdev - Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80fb8bee-20bf-4eea-9719-045e85f8f181@huawei.com>
Date: Mon, 27 Oct 2025 14:11:23 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Tianling Shen <cnsztl@...il.com>, Frank Sae <Frank.Sae@...or-comm.com>,
	Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell
 King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <shaojijie@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531


on 2025/10/26 21:36, Tianling Shen wrote:
> The LED registers on YT8531 are exactly same as YT8521, so simply
> reuse yt8521_led_hw_* functions.
>
> Tested on OrangePi R1 Plus LTS and Zero3.
>
> Signed-off-by: Tianling Shen <cnsztl@...il.com>

Reviewed-by: Jijie Shao<shaojijie@...wei.com>

> ---
>   drivers/net/phy/motorcomm.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> index a3593e663059..89b5b19a9bd2 100644
> --- a/drivers/net/phy/motorcomm.c
> +++ b/drivers/net/phy/motorcomm.c
> @@ -3048,6 +3048,9 @@ static struct phy_driver motorcomm_phy_drvs[] = {
>   		.get_wol	= ytphy_get_wol,
>   		.set_wol	= yt8531_set_wol,
>   		.link_change_notify = yt8531_link_change_notify,
> +		.led_hw_is_supported = yt8521_led_hw_is_supported,
> +		.led_hw_control_set = yt8521_led_hw_control_set,
> +		.led_hw_control_get = yt8521_led_hw_control_get,
>   	},
>   	{
>   		PHY_ID_MATCH_EXACT(PHY_ID_YT8531S),