netdev - RE: [Intel-wired-lan] [PATCH net-next v3] idpf: correct queue index in Rx allocation error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986E4E62044241BC2A9C770E5FCA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 27 Oct 2025 07:17:30 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "alok.a.tiwarilinux@...il.com" <alok.a.tiwarilinux@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next v3] idpf: correct queue index
 in Rx allocation error messages



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Alok Tiwari
> Sent: Friday, October 24, 2025 8:25 PM
> To: Lobakin, Aleksander <aleksander.lobakin@...el.com>; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; andrew+netdev@...n.ch;
> kuba@...nel.org; davem@...emloft.net; edumazet@...gle.com;
> pabeni@...hat.com; horms@...nel.org; intel-wired-lan@...ts.osuosl.org;
> netdev@...r.kernel.org
> Cc: alok.a.tiwarilinux@...il.com; alok.a.tiwari@...cle.com
> Subject: [Intel-wired-lan] [PATCH net-next v3] idpf: correct queue
> index in Rx allocation error messages
> 
> The error messages in idpf_rx_desc_alloc_all() used the group index i
> when reporting memory allocation failures for individual Rx and Rx
> buffer queues. This is incorrect.
> 
> Update the messages to use the correct queue index j and include the
> queue group index i for clearer identification of the affected Rx and
> Rx buffer queues.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
> v1 -> v2
> no change added Reviewed-by: Simon
> v2 -> v3
> added queue group index i as suggested by Alexander.
> ---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index 828f7c444d30..ed0383ab5979 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -922,8 +922,8 @@ static int idpf_rx_desc_alloc_all(struct
> idpf_vport *vport)
>  			err = idpf_rx_desc_alloc(vport, q);
>  			if (err) {
>  				pci_err(vport->adapter->pdev,
> -					"Memory allocation for Rx Queue %u
> failed\n",
> -					i);
> +					"Memory allocation for Rx queue %u
> from queue group %u failed\n",
> +					j, i);
>  				goto err_out;
>  			}
>  		}
> @@ -939,8 +939,8 @@ static int idpf_rx_desc_alloc_all(struct
> idpf_vport *vport)
>  			err = idpf_bufq_desc_alloc(vport, q);
>  			if (err) {
>  				pci_err(vport->adapter->pdev,
> -					"Memory allocation for Rx Buffer
> Queue %u failed\n",
> -					i);
> +					"Memory allocation for Rx Buffer
> Queue %u from queue group %u failed\n",
> +					j, i);
>  				goto err_out;
>  			}
>  		}
> --
> 2.50.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>