netdev - RE: [PATCH v3 net-next 2/4] net: fec: use new iterator mdiobus_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510C423FA075EBC32FFABBB88FCA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Mon, 27 Oct 2025 01:43:31 +0000
From: Wei Fang <wei.fang@....com>
To: Heiner Kallweit <hkallweit1@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, Shenwei Wang
	<shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, Siddharth
 Vadapalli <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>, Andrew
 Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>, Russell King -
 ARM Linux <linux@...linux.org.uk>, Paolo Abeni <pabeni@...hat.com>, Jakub
 Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, David Miller
	<davem@...emloft.net>
Subject: RE: [PATCH v3 net-next 2/4] net: fec: use new iterator
 mdiobus_for_each_phy

> Use new iterator mdiobus_for_each_phy() to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 1edcfaee6..c60ed8bac 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2552,7 +2552,6 @@ static int fec_enet_mii_init(struct platform_device
> *pdev)
>  	int err = -ENXIO;
>  	u32 mii_speed, holdtime;
>  	u32 bus_freq;
> -	int addr;
> 
>  	/*
>  	 * The i.MX28 dual fec interfaces are not equal.
> @@ -2667,11 +2666,8 @@ static int fec_enet_mii_init(struct platform_device
> *pdev)
>  	of_node_put(node);
> 
>  	/* find all the PHY devices on the bus and set mac_managed_pm to true */
> -	for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> -		phydev = mdiobus_get_phy(fep->mii_bus, addr);
> -		if (phydev)
> -			phydev->mac_managed_pm = true;
> -	}
> +	mdiobus_for_each_phy(fep->mii_bus, phydev)
> +		phydev->mac_managed_pm = true;
> 
>  	mii_cnt++;
> 
> --
> 2.51.1
> 
> 

Reviewed-by: Wei Fang <wei.fang@....com>