netdev - Re: [PATCH net-next v3 04/12] net: dsa: lantiq_gswip: set link parameters also for CPU port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb3692adfc83161007d82d899b45ad0ee8b6d0a2.camel@siemens.com>
Date: Mon, 27 Oct 2025 08:03:00 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "daniel@...rotopia.org" <daniel@...rotopia.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "olteanv@...il.com"
	<olteanv@...il.com>, "robh@...nel.org" <robh@...nel.org>, "lxu@...linear.com"
	<lxu@...linear.com>, "john@...ozen.org" <john@...ozen.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "yweng@...linear.com"
	<yweng@...linear.com>, "bxu@...linear.com" <bxu@...linear.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"fchan@...linear.com" <fchan@...linear.com>, "ajayaraman@...linear.com"
	<ajayaraman@...linear.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"hauke@...ke-m.de" <hauke@...ke-m.de>, "horms@...nel.org" <horms@...nel.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "jpovazanec@...linear.com"
	<jpovazanec@...linear.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v3 04/12] net: dsa: lantiq_gswip: set link
 parameters also for CPU port

Hi Daniel,

On Sun, 2025-10-26 at 23:44 +0000, Daniel Golle wrote:
> On standalone switch ICs the link parameters of the CPU port need to
> be setup just like user ports. The destinction in the driver to not
> carry out link parameter setup for the CPU port does make sense for
> in-SoC switches on which the CPU port is internally connected to the
> SoC's Ethernet MAC.
> Set link parameters also for the CPU port unless it is an internal
> interface.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

thanks for the patch!

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

(with GSW145)

> ---
>  drivers/net/dsa/lantiq/lantiq_gswip_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lantiq/lantiq_gswip_common.c b/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> index 092187603dea..0ac87eb23bb5 100644
> --- a/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> +++ b/drivers/net/dsa/lantiq/lantiq_gswip_common.c
> @@ -1459,7 +1459,7 @@ static void gswip_phylink_mac_link_up(struct phylink_config *config,
>  	struct gswip_priv *priv = dp->ds->priv;
>  	int port = dp->index;
>  
> -	if (!dsa_port_is_cpu(dp)) {
> +	if (!dsa_port_is_cpu(dp) || interface != PHY_INTERFACE_MODE_INTERNAL) {
>  		gswip_port_set_link(priv, port, true);
>  		gswip_port_set_speed(priv, port, speed, interface);
>  		gswip_port_set_duplex(priv, port, duplex);

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com