netdev - Re: [PATCH net] dpll: spec: add missing module-name and clock-id to pin-get reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0466a326-5e0b-4099-a2b9-5c5a6baaadfb@redhat.com>
Date: Mon, 27 Oct 2025 10:04:34 +0100
From: Ivan Vecera <ivecera@...hat.com>
To: Petr Oros <poros@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Donald Hunter <donald.hunter@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Milena Olech <milena.olech@...el.com>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Michal Michalik <michal.michalik@...el.com>,
 "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Cc: mschmidt@...hat.com
Subject: Re: [PATCH net] dpll: spec: add missing module-name and clock-id to
 pin-get reply

On 10/24/25 8:55 PM, Petr Oros wrote:
> The dpll.yaml spec incorrectly omitted module-name and clock-id from the
> pin-get operation reply specification, even though the kernel DPLL
> implementation has always included these attributes in pin-get responses
> since the initial implementation.
> 
> This spec inconsistency caused issues with the C YNL code generator.
> The generated dpll_pin_get_rsp structure was missing these fields.
> 
> Fix the spec by adding module-name and clock-id to the pin-attrs reply
> specification to match the actual kernel behavior.
> 
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Petr Oros <poros@...hat.com>
> ---
>   Documentation/netlink/specs/dpll.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index cafb4ec20447e1..80728f6f9bc876 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -605,6 +605,8 @@ operations:
>           reply: &pin-attrs
>             attributes:
>               - id
> +            - module-name
> +            - clock-id
>               - board-label
>               - panel-label
>               - package-label

Reviewed-by: Ivan Vecera <ivecera@...hat.com>