netdev - Re: [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44342ead-92c9-4467-b5e6-86076684e2ee@chinatelecom.cn>
Date: Tue, 28 Oct 2025 15:34:48 +0800
From: YonglongLi <liyonglong@...natelecom.cn>
To: kuba@...nel.org
Cc: netdev@...r.kernel.org, edumazet@...gle.com, horms@...nel.org
Subject: Re: [PATCH net v2 1/2] net: ip: add drop reasons when handling ip
 fragments

Hi Jakub,

Thank you for your response. I'm sorry for the late reply.
‌My email system seems to have some issues, and I loss  your reply msg.
I get your response information from web page: https://lore.kernel.org/netdev.

> Personally IDK if this is sufficiently semantically significant
> to warrant merging. FRAG_FAILED means "unidentified error during
> fragmentation"? ip_frag_next() only returns -ENOMEM and
> SKB_DROP_REASON_NOMEM already exists, so just use that.

Yes, I agree. use NOMEM instead of FRAG_FAILED.

> FRAG_OUTPUT_FAILED means something failed in output so it'd be more
> meaningful to figure out what failed there, instead of adding
> a bunch of ${CALLER}_OUTPUT_FAILED

The skb send failed in output() is frag skb, The skb droped outside of output() is the
origin skb. I think if we want to get detail drop reason we can use kfree_skb_reason
in output() (maybe anther patch set in future).
In my opinion, drop reason of the origin skb outside of output() can be not so meaningfull.

-- 
Li YongLong