netdev - Re: [PATCH 1/1] selftests: net: use BASH for bareudp testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <010a2743-b732-4e4f-b877-fed340ab3b8f@intel.com>
Date: Tue, 28 Oct 2025 14:58:09 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: <shuah@...nel.org>, Po-Hsu Lin <po-hsu.lin@...onical.com>,
	<linux-kselftest@...r.kernel.org>, <kuba@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <horms@...nel.org>, <edoardo.canepa@...onical.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] selftests: net: use BASH for bareudp testing

On 10/27/25 10:57, Po-Hsu Lin wrote:
> In bareudp.sh, this script uses /bin/sh and it will load another lib.sh
> BASH script at the very beginning.
> 
> But on some operating systems like Ubuntu, /bin/sh is actually pointed to
> DASH, thus it will try to run BASH commands with DASH and consequently
> leads to syntax issues:
>    # ./bareudp.sh: 4: ./lib.sh: Bad substitution
>    # ./bareudp.sh: 5: ./lib.sh: source: not found
>    # ./bareudp.sh: 24: ./lib.sh: Syntax error: "(" unexpected
> 
> Fix this by explicitly using BASH for bareudp.sh. This fixes test
> execution failures on systems where /bin/sh is not BASH.
> 
> Reported-by: Edoardo Canepa <edoardo.canepa@...onical.com>
> Link: https://bugs.launchpad.net/bugs/2129812
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@...onical.com>
> ---
>   tools/testing/selftests/net/bareudp.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/bareudp.sh b/tools/testing/selftests/net/bareudp.sh
> index 4046131e7888..d9e5b967f815 100755
> --- a/tools/testing/selftests/net/bareudp.sh
> +++ b/tools/testing/selftests/net/bareudp.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>   # SPDX-License-Identifier: GPL-2.0
>   
>   # Test various bareudp tunnel configurations.

this is of course a correct fix,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

what about extending checkpatch to avoid such issues in the future?
I remember at least a few such cases fixes, and I don't pay that much
attention