netdev - Re: [RFC PATCH net-next v2 2/2] net: ethernet: Implement ndo_write_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQDelXtB1--OdERb@horms.kernel.org>
Date: Tue, 28 Oct 2025 15:17:41 +0000
From: Simon Horman <horms@...nel.org>
To: I Viswanath <viswanathiyyappan@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, sdf@...ichev.me, kuniyu@...gle.com,
	ahmed.zaki@...el.com, aleksander.lobakin@...el.com,
	jacob.e.keller@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linux.dev, david.hunter.linux@...il.com,
	khalid@...nel.org
Subject: Re: [RFC PATCH net-next v2 2/2] net: ethernet: Implement
 ndo_write_rx_config callback for the 8139cp driver

On Sun, Oct 26, 2025 at 11:24:45PM +0530, I Viswanath wrote:
> Implement ndo_write_rx_config for the 8139cp driver
> 
> Signed-off-by: I Viswanath <viswanathiyyappan@...il.com>

...

> @@ -882,55 +886,53 @@ static netdev_tx_t cp_start_xmit (struct sk_buff *skb,
>  	goto out_unlock;
>  }
>  
> +static void cp_write_rx_config(struct net_device *dev)
> +{
> +	struct cp_private *cp = netdev_priv(dev);
> +	struct cp_rx_config snapshot;
> +
> +	read_snapshot((&snapshot), struct cp_private);
> +
> +	/* We can safely update without stopping the chip. */
> +	cpw32_f(RxConfig, snapshot.rx_mode);
> +
> +	cpw32_f(MAR0 + 0, snapshot.mc_filter[0]);
> +	cpw32_f(MAR0 + 4, snapshot.mc_filter[1]);
> +}Firstly, think whether you have a bug fix or new "next-like" content.
> Then once decided, assuming that you use git, use the prefix flag, i.e.

FWIIW, this patch is mangled, e.g. the lines above.

> +
>  /* Set or clear the multicast filter for this adaptor.
>     This routine is not state sensitive and need not be SMP locked. */

...