netdev - Re: [PATCH v1 net-next 10/13] mpls: Convert mpls_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUBDcAw-6kivPdcmJtwXsRHP3XRaOV2j0zOU_T0EMCOGoA@mail.gmail.com>
Date: Tue, 28 Oct 2025 10:46:24 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Guillaume Nault <gnault@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 10/13] mpls: Convert mpls_dump_routes() to RCU.

On Tue, Oct 28, 2025 at 10:41 AM Guillaume Nault <gnault@...hat.com> wrote:
>
> On Tue, Oct 28, 2025 at 03:37:05AM +0000, Kuniyuki Iwashima wrote:
> > @@ -2768,6 +2773,8 @@ static const struct rtnl_msg_handler mpls_rtnl_msg_handlers[] __initdata_or_modu
> >       {THIS_MODULE, PF_MPLS, RTM_NEWROUTE, mpls_rtm_newroute, NULL, 0},
> >       {THIS_MODULE, PF_MPLS, RTM_DELROUTE, mpls_rtm_delroute, NULL, 0},
> >       {THIS_MODULE, PF_MPLS, RTM_GETROUTE, mpls_getroute, mpls_dump_routes, 0},
> > +     {THIS_MODULE, PF_MPLS, RTM_GETROUTE, mpls_getroute, mpls_dump_routes,
> > +      RTNL_FLAG_DUMP_UNLOCKED},
>
> I can't see any reason to keep the old RTM_GETROUTE declaration here.
> It's going to be overridden by the one with RTNL_FLAG_DUMP_UNLOCKED.

Oh I think I made a mistake while rebasing and reordering patches :)

Will remove it in v2.

Thanks!

---
pw-bot: cr