netdev - Re: [PATCH v3 net-next 0/8] sctp: Avoid redundant initialisation in sctp_accept() and sctp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176161442950.1651448.1798701747287698660.git-patchwork-notify@kernel.org>
Date: Tue, 28 Oct 2025 01:20:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: marcelo.leitner@...il.com, lucien.xin@...il.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 kuni1840@...il.com, netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [PATCH v3 net-next 0/8] sctp: Avoid redundant initialisation in
 sctp_accept() and sctp_do_peeloff().

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 23 Oct 2025 23:16:49 +0000 you wrote:
> When sctp_accept() and sctp_do_peeloff() allocates a new socket,
> somehow sk_alloc() is used, and the new socket goes through full
> initialisation, but most of the fields are overwritten later.
> 
>   1)
>   sctp_accept()
>   |- sctp_v[46]_create_accept_sk()
>   |  |- sk_alloc()
>   |  |- sock_init_data()
>   |  |- sctp_copy_sock()
>   |  `- newsk->sk_prot->init() / sctp_init_sock()
>   |
>   `- sctp_sock_migrate()
>      `- sctp_copy_descendant(newsk, oldsk)
> 
> [...]

Here is the summary with links:
  - [v3,net-next,1/8] sctp: Defer SCTP_DBG_OBJCNT_DEC() to sctp_destroy_sock().
    https://git.kernel.org/netdev/net-next/c/622e8838a298
  - [v3,net-next,2/8] sctp: Don't copy sk_sndbuf and sk_rcvbuf in sctp_sock_migrate().
    https://git.kernel.org/netdev/net-next/c/2d4df59aae91
  - [v3,net-next,3/8] sctp: Don't call sk->sk_prot->init() in sctp_v[46]_create_accept_sk().
    https://git.kernel.org/netdev/net-next/c/b7185792f80a
  - [v3,net-next,4/8] net: Add sk_clone().
    https://git.kernel.org/netdev/net-next/c/151b98d10ef7
  - [v3,net-next,5/8] sctp: Use sk_clone() in sctp_accept().
    https://git.kernel.org/netdev/net-next/c/16942cf4d3e3
  - [v3,net-next,6/8] sctp: Remove sctp_pf.create_accept_sk().
    https://git.kernel.org/netdev/net-next/c/c49ed521f177
  - [v3,net-next,7/8] sctp: Use sctp_clone_sock() in sctp_do_peeloff().
    https://git.kernel.org/netdev/net-next/c/b7ddb55f3127
  - [v3,net-next,8/8] sctp: Remove sctp_copy_sock() and sctp_copy_descendant().
    https://git.kernel.org/netdev/net-next/c/71068e2e1b6b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html