netdev - Re: [PATCH 0/1] net/mlx5: query_mcia_reg fail logging at debug severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02b7f472-74c2-4510-97c7-499661b612bb@nvidia.com>
Date: Tue, 28 Oct 2025 22:27:39 +0200
From: Gal Pressman <gal@...dia.com>
To: Matthew W Carlis <mattc@...estorage.com>, netdev@...r.kernel.org
Cc: saeedm@...dia.com, tariqt@...dia.com, mbloch@...dia.com,
 ashishk@...estorage.com, msaggi@...estorage.com, adailey@...estorage.com
Subject: Re: [PATCH 0/1] net/mlx5: query_mcia_reg fail logging at debug
 severity

On 28/10/2025 21:40, Matthew W Carlis wrote:
> The commit message pretty much has most of my thoughts on this one. We
> see this message generated all the time because users are trying to
> determine if there is an SFP module installed in a port or when trying
> to get module info from a port that doesn't have an SFP module. This
> is not really an error at all

It is an error, as evident by the fact that you only changed the log
level, not the error return value.
We cannot query the module EEPROM if there's no module to query.

> & therefore the message is undesirable.

Arguable.
This is a privileged command, and error messages are intended for
errors. It's important to have the value of the status field in the logs
in case of an error.