netdev - Re: [net-next PATCH 7/8] fbnic: Add SW shim for MII interface to PMA/PMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202510290438.wwPPh1zV-lkp@intel.com>
Date: Wed, 29 Oct 2025 04:52:59 +0800
From: kernel test robot <lkp@...el.com>
To: Alexander Duyck <alexander.duyck@...il.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, kuba@...nel.org, kernel-team@...a.com,
	andrew+netdev@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
	pabeni@...hat.com, davem@...emloft.net
Subject: Re: [net-next PATCH 7/8] fbnic: Add SW shim for MII interface to
 PMA/PMD

Hi Alexander,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Duyck/net-phy-Add-support-for-25-50-and-100Gbps-PMA-to-genphy_c45_read_pma/20251025-044506
base:   net-next/main
patch link:    https://lore.kernel.org/r/176133848134.2245037.8819965842869649833.stgit%40ahduyck-xeon-server.home.arpa
patch subject: [net-next PATCH 7/8] fbnic: Add SW shim for MII interface to PMA/PMD
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20251029/202510290438.wwPPh1zV-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project e1ae12640102fd2b05bc567243580f90acb1135f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251029/202510290438.wwPPh1zV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510290438.wwPPh1zV-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/meta/fbnic/fbnic_swmii.c:17:6: warning: variable 'aui' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
      17 |         if (fbd->netdev) {
         |             ^~~~~~~~~~~
   drivers/net/ethernet/meta/fbnic/fbnic_swmii.c:22:10: note: uninitialized use occurs here
      22 |         switch (aui) {
         |                 ^~~
   drivers/net/ethernet/meta/fbnic/fbnic_swmii.c:17:2: note: remove the 'if' if its condition is always true
      17 |         if (fbd->netdev) {
         |         ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/meta/fbnic/fbnic_swmii.c:15:8: note: initialize the variable 'aui' to silence this warning
      15 |         u8 aui;
         |               ^
         |                = '\0'
   1 warning generated.


vim +17 drivers/net/ethernet/meta/fbnic/fbnic_swmii.c

     8	
     9	static int
    10	fbnic_swmii_read_pmapmd(struct fbnic_dev *fbd, int regnum)
    11	{
    12		u16 ctrl1 = 0, ctrl2 = 0;
    13		struct fbnic_net *fbn;
    14		int ret = 0;
    15		u8 aui;
    16	
  > 17		if (fbd->netdev) {
    18			fbn = netdev_priv(fbd->netdev);
    19			aui = fbn->aui;
    20		}
    21	
    22		switch (aui) {
    23		case FBNIC_AUI_25GAUI:
    24			ctrl1 = MDIO_CTRL1_SPEED25G;
    25			ctrl2 = MDIO_PMA_CTRL2_25GBCR;
    26			break;
    27		case FBNIC_AUI_LAUI2:
    28			ctrl1 = MDIO_CTRL1_SPEED50G;
    29			ctrl2 = MDIO_PMA_CTRL2_50GBCR2;
    30			break;
    31		case FBNIC_AUI_50GAUI1:
    32			ctrl1 = MDIO_CTRL1_SPEED50G;
    33			ctrl2 = MDIO_PMA_CTRL2_50GBCR;
    34			break;
    35		case FBNIC_AUI_100GAUI2:
    36			ctrl1 = MDIO_CTRL1_SPEED100G;
    37			ctrl2 = MDIO_PMA_CTRL2_100GBCR2;
    38			break;
    39		default:
    40			break;
    41		}
    42	
    43		switch (regnum) {
    44		case MDIO_CTRL1:
    45			ret = ctrl1;
    46			break;
    47		case MDIO_STAT1:
    48			ret = fbd->pmd_state == FBNIC_PMD_SEND_DATA ?
    49			      MDIO_STAT1_LSTATUS : 0;
    50			break;
    51		case MDIO_DEVS1:
    52			ret = MDIO_DEVS_PMAPMD;
    53			break;
    54		case MDIO_CTRL2:
    55			ret = ctrl2;
    56			break;
    57		case MDIO_STAT2:
    58			ret = MDIO_STAT2_DEVPRST_VAL |
    59			      MDIO_PMA_STAT2_EXTABLE;
    60			break;
    61		case MDIO_PMA_EXTABLE:
    62			ret = MDIO_PMA_EXTABLE_40_100G |
    63			      MDIO_PMA_EXTABLE_25G;
    64			break;
    65		case MDIO_PMA_40G_EXTABLE:
    66			ret = MDIO_PMA_40G_EXTABLE_50GBCR2;
    67			break;
    68		case MDIO_PMA_25G_EXTABLE:
    69			ret = MDIO_PMA_25G_EXTABLE_25GBCR;
    70			break;
    71		case MDIO_PMA_50G_EXTABLE:
    72			ret = MDIO_PMA_50G_EXTABLE_50GBCR;
    73			break;
    74		case MDIO_PMA_EXTABLE2:
    75			ret = MDIO_PMA_EXTABLE2_50G;
    76			break;
    77		case MDIO_PMA_100G_EXTABLE:
    78			ret = MDIO_PMA_100G_EXTABLE_100GBCR2;
    79			break;
    80		default:
    81			break;
    82		}
    83	
    84		return ret;
    85	}
    86	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki