[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251028214839.5015-1-mattc@purestorage.com>
Date: Tue, 28 Oct 2025 15:48:39 -0600
From: Matthew W Carlis <mattc@...estorage.com>
To: gal@...dia.com
Cc: adailey@...estorage.com,
	ashishk@...estorage.com,
	mattc@...estorage.com,
	mbloch@...dia.com,
	msaggi@...estorage.com,
	netdev@...r.kernel.org,
	saeedm@...dia.com,
	tariqt@...dia.com
Subject: Re: [PATCH 1/1] net/mlx5: query_mcia_reg fail logging at debug severity
Tue, 28 Oct 2025 22:27:39, Gal Pressman wrote:
> And if he knows, I would expect him to not run the command again?
Sometimes a user is a script or an inventory automation tool. 
> It is an error, as evident by the fact that you only changed the log
> level, not the error return value.
I don't know of any strict convention in terms of when error return codes
should have associated log messages. I wonder if there is something more targeted
that could be done. For example, if there is a "physical presence" mechanism
& a module is not present simply skip the logging.
Cheers!
- Matt
Powered by blists - more mailing lists
 
