netdev - RE: [Intel-wired-lan] [PATCH v2] i40e: avoid redundant VF link state updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898540B2805F5268F925A1B28FFAA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Wed, 29 Oct 2025 09:44:52 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Robert Malz <robert.malz@...onical.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: Jamie Bainbridge <jamie.bainbridge@...il.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, Dennis Chen <dechen@...hat.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Czapnik, Lukasz"
	<lukasz.czapnik@...el.com>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "Eric
 Dumazet" <edumazet@...gle.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, Simon Horman <horms@...nel.org>, "Keller, Jacob
 E" <jacob.e.keller@...el.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "David S . Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v2] i40e: avoid redundant VF link state
 updates

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Robert Malz
> Sent: Wednesday, October 22, 2025 6:12 PM
> To: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: Jamie Bainbridge <jamie.bainbridge@...il.com>; Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com>; Dennis Chen <dechen@...hat.com>;
> Robert Malz <robert.malz@...onical.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Czapnik, Lukasz
> <lukasz.czapnik@...el.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> Eric Dumazet <edumazet@...gle.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Keller,
> Jacob E <jacob.e.keller@...el.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; David S . Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH v2] i40e: avoid redundant VF link state
> updates
> 
> From: Jay Vosburgh <jay.vosburgh@...onical.com>
> 
> Multiple sources can request VF link state changes with identical parameters.
> For example, OpenStack Neutron may request to set the VF link state to
> IFLA_VF_LINK_STATE_AUTO during every initialization or user can
> issue: `ip link set <ifname> vf 0 state auto` multiple times. Currently, the i40e
> driver processes each of these requests, even if the requested state is the
> same as the current one. This leads to unnecessary VF resets and can cause
> performance degradation or instability in the VF driver, particularly in
> environment using Data Plane Development Kit (DPDK).
> 
> With this patch i40e will skip VF link state change requests when the desired
> link state matches the current configuration. This prevents unnecessary VF
> resets and reduces PF-VF communication overhead.
> 
> To reproduce the problem run following command multiple times on the same
> interface: 'ip link set <ifname> vf 0 state auto'
> Every time command is executed, PF driver will trigger VF reset.
> 
> Co-developed-by: Robert Malz <robert.malz@...onical.com>
> Signed-off-by: Robert Malz <robert.malz@...onical.com>
> Signed-off-by: Jay Vosburgh <jay.vosburgh@...onical.com>
> 
> ---
> V1 -> V2: updated commit message, added information how to reproduce
> 
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>