netdev - Re: [PATCH net] ptp: Allow exposing cycles only for clocks with free-running counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv0qPsfLqsrr4Wux=Zb22dQFKDngWMQbEq+qN8Yc+wNsyg@mail.gmail.com>
Date: Wed, 29 Oct 2025 15:39:39 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Carolina Jubran <cjubran@...dia.com>
Cc: Richard Cochran <richardcochran@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dragos Tatulea <dtatulea@...dia.com>, 
	Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net] ptp: Allow exposing cycles only for clocks with
 free-running counter

On Wed, Oct 29, 2025 at 2:39 PM Carolina Jubran <cjubran@...dia.com> wrote:
>
> The PTP core falls back to gettimex64 and getcrosststamp when
> getcycles64 or getcyclesx64 are not implemented. This causes the CYCLES
> ioctls to retrieve PHC real time instead of free-running cycles.
>
> Reject PTP_SYS_OFFSET_{PRECISE,EXTENDED}_CYCLES for clocks without
> free-running counter support since the result would represent PHC real
> time and system time rather than cycles and system time.
>
> Fixes: faf23f54d366 ("ptp: Add ioctl commands to expose raw cycle counter values")
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> ---
>  drivers/ptp/ptp_chardev.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
> index 8106eb617c8c..c61cf9edac48 100644
> --- a/drivers/ptp/ptp_chardev.c
> +++ b/drivers/ptp/ptp_chardev.c
> @@ -561,10 +561,14 @@ long ptp_ioctl(struct posix_clock_context *pccontext, unsigned int cmd,
>                 return ptp_mask_en_single(pccontext->private_clkdata, argptr);
>
>         case PTP_SYS_OFFSET_PRECISE_CYCLES:
> +               if (!ptp->has_cycles)
> +                       return -EOPNOTSUPP;
>                 return ptp_sys_offset_precise(ptp, argptr,
>                                               ptp->info->getcrosscycles);
>
>         case PTP_SYS_OFFSET_EXTENDED_CYCLES:
> +               if (!ptp->has_cycles)
> +                       return -EOPNOTSUPP;
>                 return ptp_sys_offset_extended(ptp, argptr,
>                                                ptp->info->getcyclesx64);
>         default:

LGTM.
Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

> --
> 2.38.1
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)