netdev - Re: [PATCH net-next 1/2] net: phy: motorcomm: correct the default rx delay config for the rgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94ef8610-dc90-4d4a-a607-17ed2ced06c6@lunn.ch>
Date: Wed, 29 Oct 2025 13:07:35 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Yi Cong <cong.yi@...ux.dev>
Cc: Frank.Sae@...or-comm.com, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
	Yi Cong <yicong@...inos.cn>
Subject: Re: [PATCH net-next 1/2] net: phy: motorcomm: correct the default rx
 delay config for the rgmii

On Wed, Oct 29, 2025 at 11:00:42AM +0800, Yi Cong wrote:
> From: Yi Cong <yicong@...inos.cn>
> 
> According to the dataSheet, rx delay default value is set to 0.

You need to be careful here, or you will break working boards. Please
add to the commit message why this is safe.

Also, motorcomm,yt8xxx.yaml says:

  rx-internal-delay-ps:
    description: |
      RGMII RX Clock Delay used only when PHY operates in RGMII mode with
      internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds.
    enum: [ 0, 150, 300, 450, 600, 750, 900, 1050, 1200, 1350, 1500, 1650,
            1800, 1900, 1950, 2050, 2100, 2200, 2250, 2350, 2500, 2650, 2800,
            2950, 3100, 3250, 3400, 3550, 3700, 3850, 4000, 4150 ]
    default: 1950

    Andrew

---
pw-bot: cr