netdev - Re: [PATCH net-next] net: phy: nxp-c45-tja11xx: config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40c9522b-f761-4ef5-880b-5b11cd4b8ba1@lunn.ch>
Date: Wed, 29 Oct 2025 13:23:46 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Andrei Botila <andrei.botila@....nxp.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>, davem@...emloft.net,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, s32@....com,
	Christophe Lizzi <clizzi@...hat.com>,
	Alberto Ruiz <aruizrui@...hat.com>,
	Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH net-next] net: phy: nxp-c45-tja11xx: config_init restore
 macsec config

On Wed, Oct 29, 2025 at 12:42:58PM +0200, Andrei Botila wrote:
> Any existing MACsec configuration should be restored when config_init is
> called.

Please could you expand the commit message. Why should they be
restored? What is clearing them? Why is this part of
link_change_notify?

By looking at the code i can see what the change is doing. But it can
be hard to say why. So the commit message should be mostly about Why?

Is this a bug fix and should be back ported?

	Andrew