netdev - Re: [PATCH] cxgb4: flower: add support for fragmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQI7VAXP3XMbYliQ@horms.kernel.org>
Date: Wed, 29 Oct 2025 16:05:40 +0000
From: Simon Horman <horms@...nel.org>
To: Harshita V Rajput <harshitha.vr@...lsio.com>
Cc: kuba@...nel.org, davem@...emloft.net, kernelxing@...cent.com,
	imx@...ts.linux.dev, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, Potnuri Bharat Teja <bharat@...lsio.com>
Subject: Re: [PATCH] cxgb4: flower: add support for fragmentation

On Tue, Oct 28, 2025 at 01:22:55PM +0530, Harshita V Rajput wrote:
> This patch adds support for matching fragmented packets in tc flower
> filters.
> 
> Previously, commit 93a8540aac72 ("cxgb4: flower: validate control flags")
> added a check using flow_rule_match_has_control_flags() to reject
> any rules with control flags, as the driver did not support
> fragmentation at that time.
> 
> Now, with this patch, support for FLOW_DIS_IS_FRAGMENT is added:
> - The driver checks for control flags using
>   flow_rule_is_supp_control_flags(), as recommended in
>   commit d11e63119432 ("flow_offload: add control flag checking helpers").
> - If the fragmentation flag is present, the driver sets `fs->val.frag` and
>   `fs->mask.frag` accordingly in the filter specification.
> 
> Since fragmentation is now supported, the earlier check that rejected all
> control flags (flow_rule_match_has_control_flags()) has been removed.
> 
> Signed-off-by: Harshita V Rajput <harshitha.vr@...lsio.com>
> Signed-off-by: Potnuri Bharat Teja <bharat@...lsio.com>

Thanks for the comprehensive commit message.

Reviewed-by: Simon Horman <horms@...nel.org>