netdev - Re: [PATCH V3] net: ethernet: ti: netcp: Standardize knav_dma_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68a4b852-4eeb-4f97-af2a-58714b59be97@intel.com>
Date: Wed, 29 Oct 2025 13:07:54 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Nishanth Menon <nm@...com>, Jakub Kicinski <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "David S. Miller"
	<davem@...emloft.net>
CC: Simon Horman <horms@...nel.org>, Uwe Kleine-König
	<u.kleine-koenig@...libre.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew
 Lunn" <andrew+netdev@...n.ch>, Santosh Shilimkar <ssantosh@...nel.org>,
	Siddharth Vadapalli <s-vadapalli@...com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH V3] net: ethernet: ti: netcp: Standardize
 knav_dma_open_channel to return NULL on error



On 10/29/2025 6:23 AM, Nishanth Menon wrote:
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index a25ebe6cd503..e69f0946de29 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -402,7 +402,7 @@ static int of_channel_match_helper(struct device_node *np, const char *name,
>   * @name:	slave channel name
>   * @config:	dma configuration parameters
>   *
> - * Returns pointer to appropriate DMA channel on success or error.
> + * Returns pointer to appropriate DMA channel on success or NULL on error.
>   */

Minor nit: you could make this a proper kdoc returns by using "Return:"
or "Returns:" here to introduce this as a section instead of just a comment.

That would fix a kdoc warning too.


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)