netdev - Re: [PATCH net v4] net: cxgb4/ch_ipsec: fix potential use-after-free in ch_ipsec_xfrm_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176170260575.2460121.12269249531898370369.git-patchwork-notify@kernel.org>
Date: Wed, 29 Oct 2025 01:50:05 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>
Cc: kuba@...nel.org, pabeni@...hat.com, yanjun.zhu@...ux.dev,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 leon@...nel.org, steffen.klassert@...unet.com, cratiu@...dia.com,
 ayush.sawal@...lsio.com, harsh@...lsio.com, atul.gupta@...lsio.com,
 herbert@...dor.apana.org.au, ganeshgr@...lsio.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net v4] net: cxgb4/ch_ipsec: fix potential use-after-free
 in
 ch_ipsec_xfrm_add_state() callback

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 24 Oct 2025 19:13:02 +0300 you wrote:
> In ch_ipsec_xfrm_add_state() there is not check of try_module_get
> return value. It is very unlikely, but try_module_get() could return
> false value, which could cause use-after-free error.
> Conditions: The module count must be zero, and a module unload in
> progress. The thread doing the unload is blocked somewhere.
> Another thread makes a callback into the module for some request
> that (for instance) would need to create a kernel thread.
> It tries to get a reference for the thread.
> So try_module_get(THIS_MODULE) is the right call - and will fail here.
> 
> [...]

Here is the summary with links:
  - [net,v4] net: cxgb4/ch_ipsec: fix potential use-after-free in ch_ipsec_xfrm_add_state() callback
    https://git.kernel.org/netdev/net/c/d8d2b1f81530

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html