netdev - Re: [PATCH net-next v5 8/9] net: ethernet: ti: am65-cpsw: add network flow classification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251028190800.2ee4f80e@kernel.org>
Date: Tue, 28 Oct 2025 19:08:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Roger Quadros <rogerq@...nel.org>
Cc: Siddharth Vadapalli <s-vadapalli@...com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell
 King <linux@...linux.org.uk>, danishanwar@...com, srk@...com,
 linux-omap@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 8/9] net: ethernet: ti: am65-cpsw: add
 network flow classification support

On Fri, 24 Oct 2025 23:46:07 +0300 Roger Quadros wrote:

> +/* rxnfc_lock must be held */
> +static void am65_cpsw_del_rule(struct am65_cpsw_port *port,
> +			       struct am65_cpsw_rxnfc_rule *rule)
> +{
> +	int loc;
> +
> +	/* reverse location as higher locations have higher priority
> +	 * but ethtool expects lower locations to have higher priority
> +	 */
> +	loc = port->rxnfc_max - rule->location - 1;
> +
> +	cpsw_ale_policer_clr_entry(port->common->ale, loc,
> +				   &rule->cfg);
> +	list_del(&rule->list);
> +	port->rxnfc_count--;
> +	port->policer_in_use_bitmask &= ~BIT(rule->location);

__clear_bit()
Please use bitmap helpers everywhere, especially for scanning 
the bitmap to find unused bits

> +	struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> +	struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
> +
> +	switch (rxnfc->cmd) {
> +	case ETHTOOL_GRXRINGS:

please implement ::get_rx_ring_count instead
-- 
pw-bot: cr