netdev - Re: [PATCH net 0/2] gve: Fix NULL dereferencing with PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQMzWoIQvSa9ywe4@horms.kernel.org>
Date: Thu, 30 Oct 2025 09:43:54 +0000
From: Simon Horman <horms@...nel.org>
To: Joshua Washington <joshwash@...gle.com>
Cc: netdev@...r.kernel.org, Tim Hostetler <thostet@...gle.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net 0/2] gve: Fix NULL dereferencing with PTP clock

On Wed, Oct 29, 2025 at 11:45:38AM -0700, Joshua Washington wrote:
> From: Tim Hostetler <thostet@...gle.com>
> 
> This patch series fixes NULL dereferences that are possible with gve's
> PTP clock due to not stubbing certain ptp_clock_info callbacks.
> 
> Tim Hostetler (2):
>   gve: Implement gettimex64 with -EOPNOTSUPP
>   gve: Implement settime64 with -EOPNOTSUPP
> 
>  drivers/net/ethernet/google/gve/gve_ptp.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Hi Joshua and Tim,

I think that the approach of enhancing the caller to only
call these callbacks if they are non NULL, as per the patch below,
seems more robust. It would fix all drivers in one go.

- [PATCH] ptp: guard ptp_clock_gettime() if neither gettimex64 nor
  https://lore.kernel.org/all/20251028095143.396385-1-junjie.cao@intel.com/