netdev - Re: [PATCH net-next v6 08/12] virtio_net: Use existing classifier if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b473a2c1-6bc7-4830-bb0b-85ec7315f7a7@nvidia.com>
Date: Thu, 30 Oct 2025 09:08:18 -0500
From: Dan Jurgens <danielj@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, mst@...hat.com,
 jasowang@...hat.com, alex.williamson@...hat.com
Cc: virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 shameerali.kolothum.thodi@...wei.com, jgg@...pe.ca, kevin.tian@...el.com,
 kuba@...nel.org, andrew+netdev@...n.ch, edumazet@...gle.com
Subject: Re: [PATCH net-next v6 08/12] virtio_net: Use existing classifier if
 possible

On 10/30/25 6:31 AM, Paolo Abeni wrote:
> On 10/27/25 6:39 PM, Daniel Jurgens wrote:
>> @@ -7082,8 +7097,9 @@ validate_classifier_selectors(struct virtnet_ff *ff,
>>  			      int num_hdrs)
>>  {
>>  	struct virtio_net_ff_selector *selector = (void *)classifier->selectors;
>> +	int i;
>>  
>> -	for (int i = 0; i < num_hdrs; i++) {
>> +	for (i = 0; i < num_hdrs; i++) {
>>  		if (!validate_mask(ff, selector))
>>  			return -EINVAL;
> 
> Minor nit: this chunk possibly belongs to in patch 6/12.
> 
> /P
> 
Yes, you're right. Thanks