netdev - Re: [PATCH net-next v4 10/12] dt-bindings: net: dsa: lantiq,gswip: add support for MaxLinear GSW1xx switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176178717757.3193497.18178330899747787205.robh@kernel.org>
Date: Wed, 29 Oct 2025 20:19:37 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Peter Christen <peter.christen@...mens.com>, 
 Hauke Mehrtens <hauke@...ke-m.de>, linux-kernel@...r.kernel.org, 
 "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
 Conor Dooley <conor+dt@...nel.org>, Vladimir Oltean <olteanv@...il.com>, 
 devicetree@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
 Liang Xu <lxu@...linear.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 "Livia M. Rosu" <lrosu@...linear.com>, Bing tao Xu <bxu@...linear.com>, 
 John Crispin <john@...ozen.org>, 
 Lukas Stockmann <lukas.stockmann@...mens.com>, 
 "Benny (Ying-Tsan) Weng" <yweng@...linear.com>, 
 Alexander Sverdlin <alexander.sverdlin@...mens.com>, netdev@...r.kernel.org, 
 Simon Horman <horms@...nel.org>, Russell King <linux@...linux.org.uk>, 
 Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew@...n.ch>, 
 Juraj Povazanec <jpovazanec@...linear.com>, 
 Avinash Jayaraman <ajayaraman@...linear.com>, 
 Andreas Schirm <andreas.schirm@...mens.com>, 
 "Fanni (Fang-Yi) Chan" <fchan@...linear.com>
Subject: Re: [PATCH net-next v4 10/12] dt-bindings: net: dsa: lantiq,gswip:
 add support for MaxLinear GSW1xx switches

On Wed, 29 Oct 2025 00:18:30 +0000, Daniel Golle wrote:
> Extend the Lantiq GSWIP device tree binding to also cover MaxLinear
> GSW1xx switches which are based on the same hardware IP but connected
> via MDIO instead of being memory-mapped.
> 
> Add compatible strings for MaxLinear GSW120, GSW125, GSW140, GSW141,
> and GSW145 switches and adjust the schema to handle the different
> connection methods with conditional properties.
> 
> Add MaxLinear GSW125 example showing MDIO-connected configuration.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
> v4:
>  * drop maxlinear,rx-inverted and maxlinear,tx-inverted properties for
>    now in favor of upcoming generic properties
> 
> v3:
>  * add maxlinear,rx-inverted and maxlinear,tx-inverted properties
> 
> v2:
>  * remove git conflict left-overs which somehow creeped in
>  * indent example with 4 spaces instead of tabs
> 
>  .../bindings/net/dsa/lantiq,gswip.yaml        | 267 +++++++++++++-----
>  1 file changed, 194 insertions(+), 73 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.example.dtb: switch@1f (maxlinear,gsw125): ports:port@4: Unevaluated properties are not allowed ('maxlinear,rx-inverted' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/dsa/lantiq,gswip.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/02272a098447ab0de6d2e9d686469fc6ce355c7d.1761693288.git.daniel@makrotopia.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.