netdev - Re: [PATCH RESEND net-next v5 2/5] amd-xgbe: introduce support ethtool selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <036e360b-9e9d-48b5-bc91-c35beb660319@bootlin.com>
Date: Thu, 30 Oct 2025 18:30:11 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Raju Rangoju <Raju.Rangoju@....com>, netdev@...r.kernel.org
Cc: pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch, Shyam-sundar.S-k@....com
Subject: Re: [PATCH RESEND net-next v5 2/5] amd-xgbe: introduce support
 ethtool selftest

Hi Raju,

On 30/10/2025 10:13, Raju Rangoju wrote:
> Add support for ethtool selftest for MAC loopback. This includes the
> sanity check and helps in finding the misconfiguration of HW. Uses the
> existing selftest infrastructure to create test packets.
> 
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>

[...]

> +static int xgbe_test_loopback_validate(struct sk_buff *skb,
> +				       struct net_device *ndev,
> +				       struct packet_type *pt,
> +				       struct net_device *orig_ndev)
> +{
> +	struct net_test_priv *tdata = pt->af_packet_priv;
> +	const unsigned char *dst = tdata->packet->dst;
> +	const unsigned char *src = tdata->packet->src;
> +	struct netsfhdr *hdr;
> +	struct ethhdr *eh;
> +	struct iphdr *ih;
> +	struct tcphdr *th;
> +	struct udphdr *uh;

Reverse xmas tree :(

With that fixed,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>