netdev - Re: [PATCH RESEND net-next v5 3/5] amd-xgbe: add ethtool phy selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4011f81-bc46-41d6-a259-f45d10c46302@bootlin.com>
Date: Thu, 30 Oct 2025 18:33:22 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Raju Rangoju <Raju.Rangoju@....com>, netdev@...r.kernel.org
Cc: pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch, Shyam-sundar.S-k@....com
Subject: Re: [PATCH RESEND net-next v5 3/5] amd-xgbe: add ethtool phy selftest

Hi Raju,

On 30/10/2025 10:13, Raju Rangoju wrote:
> Adds support for ethtool PHY loopback selftest. It uses
> genphy_loopback function, which use BMCR loopback bit to
> enable or disable loopback.

This is not strictly correct, genphy_loopback() is only used for PHYs
that don't provide a custom .set_loopback() callback. For example, C45
PHYs don't use BMCR for loopback.

> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>

With an updated commit message,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime