| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <6cfe0af8-77f9-4f3d-9494-17f4defe6558@ieee.org>
Date: Thu, 30 Oct 2025 14:47:56 -0500
From: Alex Elder <elder@...e.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>, netdev@...r.kernel.org
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>,
Niklas Söderlund <niklas.soderlund@...natech.se>,
Paul Barker <paul@...rker.dev>, Siddharth Vadapalli <s-vadapalli@...com>,
Roger Quadros <rogerq@...nel.org>, Alex Elder <elder@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Stephan Gerhold <stephan@...hold.net>,
Loic Poulain <loic.poulain@....qualcomm.com>,
Sergey Ryazanov <ryazanov.s.a@...il.com>,
Johannes Berg <johannes@...solutions.net>,
Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
Liu Haijun <haijun.liu@...iatek.com>,
Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
"Dr. David Alan Gilbert" <linux@...blig.org>, Ingo Molnar
<mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
Michael Nemanov <michael.nemanov@...com>, Kalle Valo <kvalo@...nel.org>,
Andreas Kemnade <andreas@...nade.info>,
Roopni Devanathan <quic_rdevanat@...cinc.com>,
Thomas Weißschuh <linux@...ssschuh.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jeff Johnson <jeff.johnson@....qualcomm.com>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>, imx@...ts.linux.dev,
linux-renesas-soc@...r.kernel.org, linux-omap@...r.kernel.org,
linux-wireless@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH RESEND 2/4] net: ipa: Remove redundant
pm_runtime_mark_last_busy() calls
On 10/27/25 6:50 AM, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
Acked-by: Alex Elder <elder@...cstar.com>
> ---
> drivers/net/ipa/ipa_interrupt.c | 1 -
> drivers/net/ipa/ipa_main.c | 1 -
> drivers/net/ipa/ipa_modem.c | 4 ----
> drivers/net/ipa/ipa_smp2p.c | 2 --
> drivers/net/ipa/ipa_uc.c | 2 --
> 5 files changed, 10 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrupt.c
> index 245a06997055..8336596b1247 100644
> --- a/drivers/net/ipa/ipa_interrupt.c
> +++ b/drivers/net/ipa/ipa_interrupt.c
> @@ -149,7 +149,6 @@ static irqreturn_t ipa_isr_thread(int irq, void *dev_id)
> iowrite32(pending, ipa->reg_virt + reg_offset(reg));
> }
> out_power_put:
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
>
> return IRQ_HANDLED;
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index 25500c5a6928..95a61bae3124 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -903,7 +903,6 @@ static int ipa_probe(struct platform_device *pdev)
> if (ret)
> goto err_deconfig;
> done:
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
>
> return 0;
> diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c
> index 8fe0d0e1a00f..9b136f6b8b4a 100644
> --- a/drivers/net/ipa/ipa_modem.c
> +++ b/drivers/net/ipa/ipa_modem.c
> @@ -71,7 +71,6 @@ static int ipa_open(struct net_device *netdev)
>
> netif_start_queue(netdev);
>
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
>
> return 0;
> @@ -102,7 +101,6 @@ static int ipa_stop(struct net_device *netdev)
> ipa_endpoint_disable_one(priv->rx);
> ipa_endpoint_disable_one(priv->tx);
> out_power_put:
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
>
> return 0;
> @@ -175,7 +173,6 @@ ipa_start_xmit(struct sk_buff *skb, struct net_device *netdev)
>
> ret = ipa_endpoint_skb_tx(endpoint, skb);
>
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
>
> if (ret) {
> @@ -432,7 +429,6 @@ static void ipa_modem_crashed(struct ipa *ipa)
> dev_err(dev, "error %d zeroing modem memory regions\n", ret);
>
> out_power_put:
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
> }
>
> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index fcaadd111a8a..420098796eec 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -171,7 +171,6 @@ static irqreturn_t ipa_smp2p_modem_setup_ready_isr(int irq, void *dev_id)
> WARN(ret != 0, "error %d from ipa_setup()\n", ret);
>
> out_power_put:
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
>
> return IRQ_HANDLED;
> @@ -213,7 +212,6 @@ static void ipa_smp2p_power_release(struct ipa *ipa)
> if (!ipa->smp2p->power_on)
> return;
>
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
> ipa->smp2p->power_on = false;
> }
> diff --git a/drivers/net/ipa/ipa_uc.c b/drivers/net/ipa/ipa_uc.c
> index 2963db83ab6b..dc7e92f2a4fb 100644
> --- a/drivers/net/ipa/ipa_uc.c
> +++ b/drivers/net/ipa/ipa_uc.c
> @@ -158,7 +158,6 @@ static void ipa_uc_response_hdlr(struct ipa *ipa)
> if (ipa->uc_powered) {
> ipa->uc_loaded = true;
> ipa_power_retention(ipa, true);
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
> ipa->uc_powered = false;
> } else {
> @@ -203,7 +202,6 @@ void ipa_uc_deconfig(struct ipa *ipa)
> if (!ipa->uc_powered)
> return;
>
> - pm_runtime_mark_last_busy(dev);
> (void)pm_runtime_put_autosuspend(dev);
> }
>
Powered by blists - more mailing lists