netdev - Re: [PATCH net-next 0/3] convert can drivers to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c544fdee-5b66-45dd-b3bb-75dfd8e1adc4@kernel.org>
Date: Thu, 30 Oct 2025 07:36:52 +0100
From: Vincent Mailhol <mailhol@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org,
 Jakub Kicinski <kuba@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Jacob Keller <jacob.e.keller@...el.com>,
 Marc Kleine-Budde <mkl@...gutronix.de>, Stefan Mätje
 <stefan.maetje@....eu>, socketcan@....eu,
 Manivannan Sadhasivam <mani@...nel.org>,
 Thomas Kopp <thomas.kopp@...rochip.com>,
 Oliver Hartkopp <socketcan@...tkopp.net>, Jimmy Assarsson
 <extja@...ser.com>, Axel Forsman <axfo@...ser.com>
Subject: Re: [PATCH net-next 0/3] convert can drivers to use ndo_hwtstamp
 callbacks

Hi Vadim,

On 30/10/2025 at 00:16, Vadim Fedorenko wrote:
> The patchset converts generic ioctl implementation into a pair of
> ndo_hwtstamp_get/ndo_hwtstamp_set generic callbacks and replaces
> callbacks in drivers.
Thanks for the series. I wasn't aware of the ndo_hwtstamp_{get,set}()
when I wrote the original series. The code looks nicer like this
without the need to use the copy_{from,to}_user() anymore.

I do not have access to my hardware at the moment, so I can not
test. But the code looks straightforward to me, so:

Reviewed-by: Vincent Mailhol <mailhol@...nel.org>


Yours sincerely,
Vincent Mailhol