netdev - Re: [PATCH bpf-next v6 00/15] selftests/bpf: Integrate test_xsk.c to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e576e3d-7e77-43ec-8ec2-5867dcb44960@bootlin.com>
Date: Thu, 30 Oct 2025 09:05:47 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Björn Töpel <bjorn@...nel.org>,
 Magnus Karlsson <magnus.karlsson@...el.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>,
 Shuah Khan <shuah@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Alexis Lothore <alexis.lothore@...tlin.com>,
 Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v6 00/15] selftests/bpf: Integrate test_xsk.c to
 test_progs framework

Hi,

On 10/29/25 7:54 PM, Alexei Starovoitov wrote:
> On Wed, Oct 29, 2025 at 6:52 AM Bastien Curutchet (eBPF Foundation)
> <bastien.curutchet@...tlin.com> wrote:
>>
>> Hi all,
>>
>> The test_xsk.sh script covers many AF_XDP use cases. The tests it runs
>> are defined in xksxceiver.c. Since this script is used to test real
>> hardware, the goal here is to leave it as it is, and only integrate the
>> tests that run on veth peers into the test_progs framework.
>>
>> I've looked into what could improve the speed in the CI:
>> - some tests are skipped when run on veth peers in a VM (because they
>>    rely on huge page allocation or HW rings). This skipping logic still
>>    takes some time and can be easily avoided.
>> - the TEARDOWN test is quite long (several seconds on its own) because
>>    it runs the same test 10 times in a row to ensure the teardown process
>>    works properly
>>
>> With theses tests fully skipped in the CI and the veth setup done only
>> once for each mode (DRV / SKB), the execution time is reduced to about 5
>> seconds on my setup.
>> ```
>> $ tools/testing/selftests/bpf/vmtest.sh -d $HOME/ebpf/output-regular/ -- time ./test_progs -t xsk
>> [...]
>> real    0m 5.04s
>> user    0m 0.38s
>> sys     0m 1.61s
> 
> This is fine. I see
> Summary: 2/48 PASSED, 0 SKIPPED, 0 FAILED
> 
> real    0m8.165s
> user    0m1.795s
> sys     0m4.740s
> 
> on debug kernel with kasan which is ok.
> > But it conflicts with itself :(
> 
> $ test_progs -j -t xsk
> 
> All error logs:
> setup_veth:FAIL:ip link add veth0 numtxqueues 4 numrxqueues 4 type
> veth peer name veth1 numtxqueues 4 numrxqueues 4 unexpected error: 512
> (errno 2)
> test_xsk_drv:FAIL:setup veth unexpected error: -1 (errno 2)
> #664     xsk_drv:FAIL
> Summary: 1/24 PASSED, 0 SKIPPED, 1 FAILED
> 
> Pls fix the parallel run and not by adding "_serial", of course.
Oups, in my quest for speed I removed the 'test_ns' prefix. It didn't 
seem necessary since all tests are run at once, but I forgot about 
parallel execution between the DRV and SKB modes..

Sorry about this, I'll put back the 'test_ns' prefix.

It will be a good opportunity to address some of the AI feedback I received.

Best regards,
Bastien